On Thu, Oct 13, 2011 at 03:47:16PM -0700, Ethan Jackson wrote:
> > - ? ?socklen_t rcvbuf_len;
> > - ? ?size_t rcvbuf = 0;
> > + ? ?size_t rcvbuf;
> >
> > - ? ?rcvbuf_len = sizeof rcvbuf;
> > - ? ?if (getsockopt(fd, SOL_SOCKET, SO_RCVBUF, &rcvbuf, &rcvbuf_len) < 0) {
> > - ? ? ? ?static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(5, 10);
> > - ? ? ? ?VLOG_ERR_RL(&rl, "getsockopt(SO_RCVBUF) failed: %s",
> > strerror(errno));
> > - ? ? ? ?return errno;
> > + ? ?rcvbuf = get_socket_rcvbuf(fd);
> > + ? ?if (rcvbuf < 0) {
> > + ? ? ? ?return -rcvbuf;
> > ? ? }
> > +
>
> I missed this in my original review. rcvbuf is a size_t and so will
> never be less than zero. I think you need an int.
Thanks. I fixed that.
(Why doesn't GCC warn about this? It warns about it whenever I try to
do the same thing with an enum.)
_______________________________________________
dev mailing list
[email protected]
http://openvswitch.org/mailman/listinfo/dev
