On Tue, Oct 18, 2011 at 5:01 PM, Ben Pfaff <[email protected]> wrote: > From: Justin Pettit <[email protected]> > > This makes it possible to automatically set up IPsec encrypted VXLAN > tunnels through the OVS database. > > Signed-off-by: Justin Pettit <[email protected]> > Signed-off-by: Jesse Gross <[email protected]> > [Ben modified this commit for VXLAN, added unit tests, and tweaked it] > Signed-off-by: Ben Pfaff <[email protected]>
Just a few random typos that I noticed: > diff --git a/NEWS b/NEWS > index 27bb260..540dbff 100644 > --- a/NEWS > +++ b/NEWS > @@ -2,7 +2,8 @@ Post-v1.2.0 > ------------------------ > > - New support for the experimental VXLAN tunnel protocol (see > - http://tools.ietf.org/html/draft-mahalingam-dutt-dcops-vxlan-00). > + http://tools.ietf.org/html/draft-mahalingam-dutt-dcops-vxlan-00) > + and VXLAN over IPSEC. I think in most places we use the capitalization IPsec but we use IPSEC in a few places here. > diff --git a/debian/control b/debian/control > index 1f3387a..4c23e59 100644 > --- a/debian/control > +++ b/debian/control > @@ -60,9 +60,9 @@ Depends: > openvswitch-common (= ${binary:Version}), > openvswitch-switch (= ${binary:Version}), > python-openvswitch (= ${source:Version}) > -Description: Open vSwitch GRE-over-IPsec support > +Description: Open vSwitch support for GRE and VXLAN over ISPEC IPSEC instead of ISPEC. > diff --git a/lib/netdev-vport.c b/lib/netdev-vport.c > index 9db93ba..d2c9e14 100644 > --- a/lib/netdev-vport.c > +++ b/lib/netdev-vport.c > @@ -135,11 +135,27 @@ netdev_vport_get_vport_type(const struct netdev *netdev) > : OVS_VPORT_TYPE_UNSPEC); > } > > -const char * > -netdev_vport_get_netdev_type(const struct dpif_linux_vport *vport) > +static const char * > +get_maybe_ipsec_tunnel_type(const struct dpif_linux_vport *vport, > + const char *plain_type, const char *ipsec_type) > { > struct nlattr *a[OVS_TUNNEL_ATTR_MAX + 1]; > + uint32_t flags; > + > + if (tnl_port_config_from_nlattr(vport->options, vport->options_len, a)) { > + VLOG_WARN_RL(&rl, "dp%d: cannot parse options for port `%s' (type > %u)", The first single quote is of a different type. _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
