On Fri, Oct 21, 2011 at 06:32:43PM -0700, Jesse Gross wrote: > On Fri, Oct 21, 2011 at 5:12 PM, Ben Pfaff <[email protected]> wrote: > > diff --git a/datapath/datapath.c b/datapath/datapath.c > > index de2f76b..d3147eb 100644 > > --- a/datapath/datapath.c > > +++ b/datapath/datapath.c > > @@ -512,24 +512,29 @@ static int validate_actions(const struct nlattr *attr, > > ??static int validate_sample(const struct nlattr *attr, > > ?? ?? ?? ?? ?? ?? ?? ?? ?? ?? ?? ?? ?? ?? ?? ??const struct sw_flow_key > > *key, int depth) > [...] > > - ?? ?? ?? if (!a[OVS_SAMPLE_ATTR_PROBABILITY]) > > + ?? ?? ?? memset(attrs, 0, sizeof attrs); > > Kernel style wants parentheses to go with sizeof but otherwise looks good to > me.
Thanks for the reminder, I always forget that point. > Acked-by: Jesse Gross <[email protected]> Great, I'll test this and push it. _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
