This doesn't matter for any of the current users of ACTION, nor do I expect it to matter, but it seems like a good idea nonetheless.
Signed-off-by: Ben Pfaff <[email protected]> --- datapath/datapath.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/datapath/datapath.c b/datapath/datapath.c index dab8631..be90d54 100644 --- a/datapath/datapath.c +++ b/datapath/datapath.c @@ -552,7 +552,7 @@ static int validate_action_key(const struct nlattr *a, nla_len(ovs_key) != ovs_key_lens[key_type]) return -EINVAL; -#define ACTION(act, key) ((act << 8) | key) +#define ACTION(act, key) (((act) << 8) | (key)) switch(ACTION(act_type, key_type)) { const struct ovs_key_ipv4 *ipv4_key; -- 1.7.4.4 _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
