On Fri, Oct 21, 2011 at 06:42:00PM -0700, Ethan Jackson wrote:
> Should sodepends.pl be copyright 2008, 2011 as well as 2011?
It's derived from soexpand.pl which has a 2008 copyright, so my
(imperfect) understanding of the rules is that the earlier copyright
year should be retained.
> I think the indentation is messed up with the OUTER: loop in
> sodepends, not sure what the correct style is though so it might be
> correct. Quick google search was inconclusive.
I changed it from
OUTER: while (<OUTER>) {
to
OUTER:
while (<OUTER>) {
which I also think looks better.
I don't remember where i got that ugly style from. Maybe it's just what
Emacs did.
> Did you intentionally add manpages.mk to the commit? I would think it
> would get built the first time someone calls make.
This is nastier than it looks at first. Automake is what does the
include processing here (take a look at the generated Makefile in your
build directory: it won't have any include directive from this).
Automake will error out if an include file is missing. That means that
we need to include *some* manpages.mk, and it might as well be the right
one (otherwise you have to somehow trigger regenerating it on
checkout).
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
