On Fri, Oct 28, 2011 at 5:03 PM, Pravin B Shelar <[email protected]> wrote: > diff --git a/lib/flow.c b/lib/flow.c > index 06cc822..2785554 100644 > --- a/lib/flow.c > +++ b/lib/flow.c > @@ -325,7 +325,7 @@ invalid: > */ > void > flow_extract(struct ofpbuf *packet, ovs_be64 tun_id, uint16_t ofp_in_port, > - struct flow *flow) > + uint32_t priority, struct flow *flow)
Everywhere else we generally use the order priority, tun_id, in_port. I think it is helpful to keep them consistent seeing as these fields are all just numbers. > diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c > index aba8e3c..b1602dc 100644 > --- a/ofproto/ofproto-dpif.c > +++ b/ofproto/ofproto-dpif.c > @@ -5274,7 +5271,7 @@ ofproto_unixctl_trace(struct unixctl_conn *conn, const > char *args_, > ds_put_cstr(&result, s); > free(s); > > - flow_extract(packet, tun_id, in_port, &flow); > + flow_extract(packet, tun_id, in_port, 0, &flow); Seeing as the priority can affect the kernel actions that are emitted I think that it is important to allow it be specified as metadata to the trace command. Otherwise, it can give misleading results, which is not good for a debugging tool. _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
