On Mon, Oct 31, 2011 at 7:45 PM, Pravin B Shelar <[email protected]> wrote: > diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c > index d0a5e00..9ff2534 100644 > --- a/ofproto/ofproto-dpif.c > +++ b/ofproto/ofproto-dpif.c > @@ -5258,18 +5256,20 @@ ofproto_unixctl_trace(struct unixctl_conn *conn, > const char *args_, > packet = ofpbuf_new(0); > flow_compose(packet, &flow); > } > - } else if (dpname && arg1 && arg2 && arg3) { > - /* ofproto/trace dpname tun_id in_port packet */ > + } else if (dpname && arg1 && arg2 && arg3 && arg4) { > + /* ofproto/trace dpname priority tun_id in_port packet */ > uint16_t in_port; > ovs_be64 tun_id; > + uint32_t priority; > > - tun_id = htonll(strtoull(arg1, NULL, 0)); > - in_port = ofp_port_to_odp_port(atoi(arg2)); > + priority = strtoul(arg1, NULL, 0);
It might be slightly better to use atoi() instead of stroul() since that's what we use in other places where we expect data in decimal (i.e. in_port) but that's minor. Otherwise looks good: Acked-by: Jesse Gross <[email protected]> _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
