On Mon, Nov 7, 2011 at 1:53 PM, Pravin Shelar <[email protected]> wrote: > On Mon, Nov 7, 2011 at 1:35 PM, Jesse Gross <[email protected]> wrote: >> You remove a lot of included header files throughout this patch. How >> did you come up with the list? It seems like the minimum set but >> usually the rule is that if you use something directly then you should >> include the header file even if something else that you use also >> happens to include it. > > Yes, it is minimum set. > I am not sure why do we need to include header even if it is included > indirectly.
Because it makes it really sensitive to changes in the implementation of other components of the system, kernel configuration, architecture, etc. See here for some discussion: https://lkml.org/lkml/2011/1/9/63 _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
