On Tue, Nov 15, 2011 at 10:10:02AM -0800, Justin Pettit wrote: > On Nov 15, 2011, at 9:17 AM, Ben Pfaff wrote: > > > On Tue, Nov 15, 2011 at 01:48:51AM -0800, Justin Pettit wrote: > >> If a port is removed when spanning tree was configured on it, then the > >> system may crash, since the STP library will try to send packets out a > >> now non-existant port. This commit disables STP on ports when they are > >> destroyed. > > > > Wouldn't it be better to do this in ofproto-dpif? The ofproto > > external interface shouldn't have nasty pitfalls like this. > > Good point. I think we can even move it up into ofproto, itself. > Below, is a revised version of the patch.
I like the new version, except that my dictionary says s/existant/existent/. Thanks, Ben. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
