On Tue, Nov 22, 2011 at 04:29:36PM -0800, Ethan Jackson wrote: > The dscp column of the queue table instructs Open vSwitch to mark > all traffic egressing the queue with the given DSCP bits in its tos > field. > > Bug #7046.
Could you move the hmap_node to the start of struct priority_node? hmap_node contains a pointer and so on 64-bit systems putting it after a uint32_t will needlessly add extra padding. There should be comments explaining what a priority_node and the priorities map are for. I wonder whether priority_node is the most informative possible name. Both "priority" and "node" are very generic computer science terms and so the name priority_node doesn't pop out as being descriptive. Maybe something like "queue_marking", "qos_to_dscp", etc. would be more meaningful. The word "priority" is kind of lousy in this context. It's the name kernel uses in sk_buff, but it's not a good or meaningful name since it's actually a handle for a queue, not a priority at all. I don't think the comments on the "set_queues" function pointer or the ofproto_port_set_queues() function are very good. It makes it sounds like the 'queues' elements actually describe QoS in some way. (Why is Queue capitalized?) It really just describes a mapping from an OpenFlow queue ID to the DSCP value to use, right? If there's an element, we use that DSCP, otherwise we use the incoming DSCP, as I understand it. vswitch.xml: s/explicity/explicitly/ Thanks, Ben. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
