On Wed, Nov 23, 2011 at 12:18:39PM -0800, Ethan Jackson wrote:
> > This is only desirable for use with VLAN splinters and should be reverted>
> > when this feature is no longer needed. ?I'm breaking it out here only to>
> > make the series easier to review.
> I think we should have an XXX comment in the code to this affect.
> It's going to be easy to forget if this information is only in the
> commit message.
Yes, good idea. I added this comment above the declaration of the
'initial_tci' member of struct subfacet:
/* This value is normally the same as ->facet->flow.vlan_tci. Only VLAN
* splinters can cause it to differ. This value should be removed when
* the VLAN splinters feature is no longer needed. */
> ? ? ?if (cookie.type == USER_ACTION_COOKIE_SFLOW) {
> ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ??? ? ? ? ?if (ofproto->sflow) {
> ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?-
> ? ? ? ?odp_flow_key_to_flow(upcall->key, upcall->key_len, &flow);
>
> dpif_sflow_received(ofproto->sflow, upcall->packet, &flow, &cookie);
>
> ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ??While you're
> here, could you please break up this dpif_sflow line, it's
> ? ? ? ? ? ? ? ? ? ??slightly too long.
OK, I added a new-line.
_______________________________________________
dev mailing list
[email protected]
http://openvswitch.org/mailman/listinfo/dev
