On Nov 22, 2011, at 3:27 PM, Ben Pfaff wrote:
> +/* Performs periodic activity required by 'ofproto' that needs to be done
> + * with the least possible latency.
> + *
> + * It makes sense to call this function a couple of times per poll loop, to
> + * provide a significant performance boost on some benchmarks with the
> + * ofproto-dpif implementation. */
> +void
> +ofproto_run_fast(struct ofproto *p)
> +{
> + if (p->ofproto_class->run_fast) {
> + p->ofproto_class->run_fast(p);
> + }
> +}
I think the only interesting return value from ofproto_run() was ENODEV. I
believe that's now detected in handle_upcalls(), which is now called through
the run_fast() "method". So, I think the ENODEV handling in ofproto_run()
belongs in ofproto_run_fast(), and the run_fast() "method" should have a return
value. Then, I think bridge_run() and bridge_run_fast() need to be updated.
Otherwise, looks good. This is a fantastic series. Thanks!
--Justin
_______________________________________________
dev mailing list
[email protected]
http://openvswitch.org/mailman/listinfo/dev
