On Thu, Dec 01, 2011 at 07:55:21PM -0800, Ansis Atteka wrote:
> Some while ago Netlink Family names were changed from ODP_*
> to OVS_*. This leaded to upgrade related issues when the new ovs-dpctl
> wanted to remove existing datapaths from the old kernel module
> by using 'ovs_datapath' instead of 'odp_datapath' name.
>
> Issue #8548
I believe that adding some compatibility is the right approach, but I
think that this is not the right way to do it.
We can't modify include/linux/openvswitch.h for this because that file
is supposed to go upstream.
I don't think that we should make dpif-linux.c treat the older
"odp_datapath" identically to the newer "ovs_datapath", because there
are undoubtedly important changes that will cause many (most?)
operations to fail in the older protocol.
I would:
* Put the definitions we need in a separate header file.
* Log a warning when the fallback datapath is opened.
* Support only the most basic operations, e.g. dump, open,
close, destroy, and fail the rest with an error.
I think it might be reasonable, in fact, to define this as a
completely separate dpif named, e.g., "linux-old" in a file like
lib/dpif-linux-old.c. That would make it very easy to remove later.
_______________________________________________
dev mailing list
[email protected]
http://openvswitch.org/mailman/listinfo/dev
