On Wed, Dec 7, 2011 at 8:19 PM, Ben Pfaff <[email protected]> wrote:

> On Tue, Nov 29, 2011 at 10:36:35PM -0800, Ben Pfaff wrote:
> > This commit switches from using the actual protocol values of error codes
> > internally in Open vSwitch, to using abstract values that are translated
> to
> > and from protocol values at message parsing and serialization time.  I
> > believe that this makes the code easier to read and to write.
> >
> > This is also one step along the way toward OpenFlow 1.1 support because
> > OpenFlow 1.1 renumbered a bunch of error codes.
>
> This patch is now included in the "of1.1 draft" series:
>        http://openvswitch.org/pipermail/dev/2011-December/013587.html


Glanced over the python, seems correct.  You could drop the leading '^'
from re.match, as match only searches from the beginning, re.search
allows matches anywhere.  The current way has no real performance
hit and is perhaps more obvious though.

  -Reid


>
> _______________________________________________
> dev mailing list
> [email protected]
> http://openvswitch.org/mailman/listinfo/dev
>
_______________________________________________
dev mailing list
[email protected]
http://openvswitch.org/mailman/listinfo/dev

Reply via email to