On Tue, Dec 27, 2011 at 8:17 PM, Pravin Shelar <pshe...@nicira.com> wrote: > On Thu, Dec 22, 2011 at 5:01 PM, Jesse Gross <je...@nicira.com> wrote: >> On Dec 21, 2011, at 8:28 PM, Pravin B Shelar wrote: >>> + skb_get(genlmsg_skb); >>> + >>> + nlh = genlmsg_put(genlmsg_skb, 0, 0, &genl_exec_family, >>> NLM_F_REQUEST, GENL_EXEC_RUN); >> >> Is it possible to do this once when the skb is allocated or does Netlink >> actually change the contents of the skb? If not, then I think we could >> avoid all the resetting at the end as well. >> > I wanted to do same. But netlink_rcv_skb() does skb_pull(). So some > sort of resetting is required in any case.
That is unfortunate. In that case, what you have seems fine. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
