On Wed, Dec 28, 2011 at 05:52:36PM -0800, Ethan Jackson wrote: > This will make the memory ownership clearer when future patches > make more extensive use of ofputil_packet_in.
This does seem like an improvement. Did you also consider replacing the ofpbuf pointer by pointer and length members? The comments on connmgr_send_packet_in() and schedule_packet_in() need updates. So does the comment on ofputil_encode_packet_in(), although that comment is already a little confused since it ends by saying that it's more efficient than itself, in a special case. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
