On Thu, Jan 05, 2012 at 06:52:35PM -0800, Gurucharan Shetty wrote:
> Currently system-type and system-version can only be set through
> ovs-vsctl and ovs-ctl in the commandline. This patch allows you
> to place system-type.conf and system-version.conf files in $etcdir
> and their contents will be used if no arguments are specified with
> ovs-vsctl or ovs-ctl.
> 
> Issue: #9033
> 
> Signed-off-by: Gurucharan Shetty <[email protected]>

Welcome!

Our most common style is to write "Bug #9033" instead of "Issue: #9033".

I'd prefer to be able to set only one or the other of these, instead of
being required to set both.

You should also update utilities/ovs-ctl.8 to describe the new behavior.

You should also add yourself to AUTHORS as part of your first patch.

Thanks,

Ben.
_______________________________________________
dev mailing list
[email protected]
http://openvswitch.org/mailman/listinfo/dev

Reply via email to