On Sat, Jan 07, 2012 at 11:11:47AM -0800, Ethan Jackson wrote:
> We should never push a VLAN tag with the CFI bit set.  This patch
> defensively enforces this invariant.

I see two callers that mask this bit out now-redundantly:

lib/dpif-netdev.c:            eth_push_vlan(packet, vlan->vlan_tci & 
~htons(VLAN_CFI));
lib/flow.c:        eth_push_vlan(b, flow->vlan_tci & ~htons(VLAN_CFI));

Will you please fold in changes to stop them doing that?

Thanks,

Ben.
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to