On Mon, Jan 09, 2012 at 07:02:33PM -0800, Ethan Jackson wrote: > > In ofputil_decode_packet_in(), I think that the following fails to > > byte-swap in_port or the registers and their masks: > >> + ? ? ? ?pin->fmd.in_port = rule.flow.in_port; > >> + > >> + ? ? ? ?pin->fmd.tun_id = rule.flow.tun_id; > >> + ? ? ? ?pin->fmd.tun_id_mask = rule.wc.tun_id_mask; > >> + > >> + ? ? ? ?memcpy(pin->fmd.regs, rule.flow.regs, sizeof pin->fmd.regs); > >> + ? ? ? ?memcpy(pin->fmd.reg_masks, rule.wc.reg_masks, > >> + ? ? ? ? ? ? ? sizeof pin->fmd.reg_masks); > > I'm sorry I don't think I understand this comment. Are you talking > about byte order? Or perhaps you are saying that we should be applying > the mask to the fmd field? I must be missing something obvious.
Never mind, I was misreading what we were copying from here. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
