> +/* Removes 'old' from its oftable then, if 'new' is nonnull, inserts 'new'.
> */
> +static void
> +oftable_substitute_rule(struct rule *old, struct rule *new)
> +{
> + oftable_remove_rule(old);
> + if (new) {
> + oftable_replace_rule(new);
> + }
> +}
Could you do oftable_remove_rule() as an else condition of the if
(new) block? Probably doesn't matter in particular, that's just what
the original code did. Seems marginally more efficient as well.
Looks good,
Ethan
_______________________________________________
dev mailing list
[email protected]
http://openvswitch.org/mailman/listinfo/dev
