On Wed, Feb 15, 2012 at 02:06:04PM +0000, Dominic Curran wrote: > Fix bug in commit 3249bb907a1dab9b0 > > Incorrectly assume that get_all_records_where() returned a list. > It infact returns a disctionary and the list iteratory needs to change > to account for this. > Thanks to Nicira for pointing this out. > > Signed-off-by: Rob Hoes <[email protected]> > Acked-by: Dominic Curran <[email protected]>
Thank you for the patch. There is a minor procedural problem here though: the sign-off is wrong. If you wrote the patch, then you should sign off. If Rob wrote the patch, and you are just posting it, then there should be a "From: Dominic Curran <[email protected]>" as the first line of the body of the message. Less importantly, according to out-of-band information I have, we should also have the following at the bottom above the sign-offs: NIC-454. Reported-by: David Tsai <[email protected]> Thanks, Ben. _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
