On Wed, Feb 15, 2012 at 8:56 AM, Ben Pfaff <b...@nicira.com> wrote: > On Wed, Feb 15, 2012 at 04:59:31PM +0000, Dominic Curran wrote: >> Fix bug in commit 3249bb907a1dab9b0 >> >> Incorrectly assume that get_all_records_where() returned a list. >> It infact returns a disctionary and the list iteratory needs to change >> to account for this. >> Thanks to Nicira for pointing this out. >> >> NIC-454. >> >> Reported-by: David Tsai <dt...@nciira.com> >> From: Rob Hoes <rob.h...@citrix.com> >> Acked-by: Dominic Curran <dominic.cur...@citrix.com> > > This version has no Signed-off-by at all, and the From: is in the wrong > place (at the end instead of the beginning). > > Here's what I need: > >> From: Rob Hoes <rob.h...@citrix.com> >> >> Fix bug in commit 3249bb907a1dab9b0 >> >> Incorrectly assume that get_all_records_where() returned a list. >> It infact returns a disctionary and the list iteratory needs to change >> to account for this. >> Thanks to Nicira for pointing this out. >> >> NIC-454. >> >> Signed-off-by: Rob Hoes <rob.h...@citrix.com> >> Reported-by: David Tsai <dt...@nciira.com> >> Acked-by: Dominic Curran <dominic.cur...@citrix.com> > > If that's correct then just let me know and I will push it in that form.
Technically it should have a signed-off-by line from Dominic as well instead of an acked-by, since he's handling the patch. There's also a typo in David's email address. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
