Thanks Ben for running sparse and for other inputs. I have installed sparse and am running make C=1, didn't see the warning. I know there is a problem in the code just wanted to check if it's the correct way?
All mpls related openflow definitions are in openflow.h. I didn't think them as a nicira extension hence added them as per OF 1.1 spec definition into openflow.h file. Should these be moved to nicira-ext.h? Just the definitions or should adhere to nicira extension header and other things? Are you referring to ofp actions when you mention "I couldn't find the OFP_MPLS_* definitions". Mpls ofp actions are in openflow.h and mpls match are added as nicira extension. Diffs doesn't include mpls match related changes. Thanks Ravi _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev