On Thu, Mar 01, 2012 at 04:30:37PM -0800, Ethan Jackson wrote: > The ovs_error() and ovs_fatal() helper functions are useful enough > to be ported to Python. A user will be added in a future commit. > > Signed-off-by: Ethan Jackson <et...@nicira.com>
Looks good to me. In the final case in ovs_retval_to_string(), I think I'd use %s instead of %d: maybe some non-integer value got passed in and my instinct is that it's probably better to convert it to a string than to throw an exception. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev