On Fri, Mar 02, 2012 at 01:30:02PM -0800, Ethan Jackson wrote:
> > Will you convert the existing Idl clients in the tree to use this new
> > class?
> 
> Sure, do you mind if I do it a bit later as I convert the python
> daemons to using the new unixctl library.  That way I only have to
> test them once.
> 
> > Should we continue to support the older form?
> 
> I don't feel strongly about it either way.  I suppose supporting
> multiple methods is confusing if only one is being used.  We can alway
> add support fo the older method if I rip it out.

OK, that's all fine.

The commit looks fine.  The only question I have is whether
SchemaHelper.__init__() should accept a schema file name (or a schema
itself)?  Currently there's no interface for overriding the default
except to assign the property directly (but maybe that's OK?  I'm not
certain about proper Python style).
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to