Looks good to me. Ethan
On Wed, Mar 7, 2012 at 15:27, Ben Pfaff <[email protected]> wrote: > The "speed_hi" member was only introduced in 2.6.27, so builds against > older kernel headers failed. > > speed_hi is fully backward compatible with older kernels, because older > kernels always set it to 0, so we could easily introduce a compatibility > layer here, but in fact I don't know of any OVS users who have interfaces > faster than 65.5 Gb/s, so it's hardly urgent. > > Signed-off-by: Ben Pfaff <[email protected]> > --- > lib/netdev-linux.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/lib/netdev-linux.c b/lib/netdev-linux.c > index 939221b..3c474e3 100644 > --- a/lib/netdev-linux.c > +++ b/lib/netdev-linux.c > @@ -1498,7 +1498,7 @@ netdev_linux_get_features(const struct netdev *netdev, > } > > /* Current settings. */ > - speed = (ecmd.speed_hi << 16) | ecmd.speed; > + speed = ecmd.speed; > if (speed == SPEED_10) { > *current = ecmd.duplex ? NETDEV_F_10MB_FD : NETDEV_F_10MB_HD; > } else if (speed == SPEED_100) { > -- > 1.7.2.5 > > _______________________________________________ > dev mailing list > [email protected] > http://openvswitch.org/mailman/listinfo/dev _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
