On Thu, Mar 08, 2012 at 07:26:30AM -0800, Pravin B Shelar wrote:
> Fixed according to comments from Ben.
> v1-v2:
> - Changed check for VALID_ETHERADDR
> - Using notifier msg to update device ether addr.
> - Removed hwaddr_family param from set_etheraddr().
>
> --8<--------------------------cut here-------------------------->8--
>
> Signed-off-by: Pravin B Shelar <[email protected]>
I don't think it's a good idea to cache errors in
netdev_linux_set_etheraddr() for the same reason as caching errors
setting MTU.
The comment on netdev_linux_get_etheraddr() is obsolete. It's not
your fault, but please do update it.
In rtnetlink_link_parse(), please remove the .max_len from the
IFLA_ADDRESS policy. It would cause netlink parsing errors for
unusual kinds of interfaces, without much benefit.
In rtnetlink_link_parse(), there's an extra set on parentheses on the
second line below:
+ if (attrs[IFLA_ADDRESS] &&
+ (nl_attr_get_size(attrs[IFLA_ADDRESS]) == ETH_ALEN)) {
+ memcpy(change->addr, nl_attr_get(attrs[IFLA_ADDRESS]), ETH_ALEN);
+ } else {
Otherwise this looks good. Thank you.
_______________________________________________
dev mailing list
[email protected]
http://openvswitch.org/mailman/listinfo/dev
