On Tue, Apr 03, 2012 at 01:42:11PM -0700, Arun Sharma wrote:
> This is an improvement in {ovs|xen}-bugtool archive output to determine the
> version which
> was running for all the OVS binaries/daemons. It is implemented as a plugin
> which internally
> calls "ovs-appctl -t <daemon> version" for daemons/binaries whose pid file is
> present in
> /var/run/openvswitch directory.
>
> Feature #10383
> Signed-off-by: Arun Sharma <arun.sha...@calsoftinc.com>
This looks good. I have only a few comments.
The lines in your commit message are too long. Please wrap them to no
more than 79 characters (or fewer; I use 75).
"git am" says:
Applying: bugtool - Collect version info for all running open Vswitch
daemons/binaries.
/home/blp/ovs2/.git/rebase-apply/patch:98: trailing whitespace.
warning: 1 line adds whitespace errors.
In utilities/bugtool/ovs-bugtool-daemons-ver, I think we should
redirect stderr to /dev/null (e.g. 2>/dev/null) in the ls call, in
case there are no .pid files. Also please put a space after the ";"
> +for f in `cd /var/run/openvswitch/;ls *.pid`
> +do
It seems a little odd to worry about a file named just ".pid",
although I guess it doesn't hurt:
> + if [ -n "${f%.pid}" ]; then
> + ovs-appctl -t "${f%.pid}" version 2>&1
> + fi
> + echo
> +done
Thanks,
Ben.
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
