On Fri, Apr 13, 2012 at 05:58:28PM -0700, Ethan Jackson wrote:
> > + if (n_bits <= 64) {
> > + mf_set_subfield(&dst, value, &rule);
> > + } else {
> > + /* We're only setting subfields to allow us to check
> > + * prerequisites. No prerequisite depends on the
> > value of
> > + * a field that is wider than 64 bits. So just skip
> > + * setting it entirely. */
> > + }
>
> Is there some sort of assertion we could make here in case this
> assumption changes in the future? If there isn't anything convenient,
> I think the comment is sufficient.
I added a
BUILD_ASSERT_DECL(FLOW_WC_SEQ == 9);
which should draw attention to most changes that could affect this
property.
> Everything else looks good, thanks.
Thanks, I'll do some final testing and push this.
_______________________________________________
dev mailing list
[email protected]
http://openvswitch.org/mailman/listinfo/dev
