Looks good to me, thanks. Ethan
On Tue, Apr 24, 2012 at 10:53, Ben Pfaff <[email protected]> wrote: > On Tue, Apr 24, 2012 at 05:52:28PM +0000, Kyle Mestery (kmestery) wrote: >> On Apr 24, 2012, at 12:44 PM, Ben Pfaff wrote: >> >> > CC: Ethan Jackson <[email protected]> >> > Signed-off-by: Ben Pfaff <[email protected]> >> > --- >> > vswitchd/bridge.c | 2 +- >> > 1 files changed, 1 insertions(+), 1 deletions(-) >> > >> > diff --git a/vswitchd/bridge.c b/vswitchd/bridge.c >> > index 077d9ee..833973a 100644 >> > --- a/vswitchd/bridge.c >> > +++ b/vswitchd/bridge.c >> > @@ -1306,7 +1306,7 @@ iface_create(struct bridge *br, struct if_cfg >> > *if_cfg, int ofp_port) >> > error = ofproto_port_add(br->ofproto, iface->netdev, >> > &new_ofp_port); >> > if (!error) { >> > VLOG_INFO("bridge %s: added interface %s (%d)", br->name, >> > - iface->name, ofp_port); >> > + iface->name, new_ofp_port); >> > iface_set_ofp_port(iface, new_ofp_port); >> > } else { >> > netdev_close(iface->netdev); >> >> Nice catch, will be good to have this in the logs accurately! > > Thanks for the review. > > This bug has only been there since late yesterday, so I doubt anyone > has really been burned yet. > > Ethan? _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
