On Wed, Apr 25, 2012 at 09:16:33PM -0700, Ethan Jackson wrote:
> Before this patch, rconn_send() would delete 'b' on success, and
> not on error.  This is confusing and error-prone.  This patch
> causes rconn_send() to always delete 'b'.
> 
> Signed-off-by: Ethan Jackson <[email protected]>

> +/* Sends 'b' on 'rc'.  Returns 0 if successful, or ENOTCONN if 'rc' is not
> + * currently connected.  In either case, 'b' is deleted.

I think it would be better to say that ownership of 'b' gets
transferred to 'rc'; it won't necessarily be deleted immediately.

Either way this is an improvement, thank you.
_______________________________________________
dev mailing list
[email protected]
http://openvswitch.org/mailman/listinfo/dev

Reply via email to