On Wed, May 02, 2012 at 01:27:41PM -0700, Justin Pettit wrote:
> On May 2, 2012, at 12:56 PM, Ben Pfaff wrote:
>
> > +\fIniceness\fR may also take one of the following special values.
>
> I understand that enabling these features are mutually exclusive
> with setting the niceness, but it seems odd to overload the term
> since these programs have nothing to do with niceness. As we talked
> about in person, it might be clearer if a new option were provided
> such as "wrapper".
I'll think about that.
> > +These special values great slow daemon operations so they should not
>
> "greatly"?
Thanks, fixed.
> > - if test X"$priority" != X; then
> > + if test X"$priority" = Xvalgrind; then
>
> This is a nit, but the man page describes this variable as
> "niceness", but it's "priority" here. It might be nice to use the
> same name in both locations.
OK, I'll do that.
> > + if (valgrind --version) > /dev/null 2>&1; then
> > + set valgrind -q --leak-check=full
> > --log-file="$logdir/$daemon.valgrind.log.%p" "$@"
> > + else
> > + log_failure_msg "valgrind not installed, running $daemon
> > without it"
> > + fi
> > + elif test X"$priority" = Xstrace; then
> > + if (strace -V) > /dev/null 2>&1; then
> > + set strace -ff -o "$logdir/$daemon.strace.log" "$@"
>
> It doesn't look like you have the process id in the file name as
> described in the man page.
That's what -ff does, see strace(1):
-ff If the -o filename option is in effect, each pro‐
cesses trace is written to filename.pid where pid is
the numeric process id of each process. This is
incompatible with -c, since no per-process counts
are kept.
> Thanks for putting this together--it will be useful.
You're welcome.
_______________________________________________
dev mailing list
[email protected]
http://openvswitch.org/mailman/listinfo/dev
