On Thu, May 03, 2012 at 08:19:07PM -0700, Gurucharan Shetty wrote:
> Add scripts that will allow Open vSwitch bridges and ports to be
> configured through /etc/network/interfaces. This patch follows a
> very similar style as OVS network integration for rhel.
>
> Signed-off-by: Gurucharan Shetty <[email protected]>
This is great. Thank you.
I didn't test this at all; I'm sure that you did.
Could we change the "if" and its enclosed statement below to just:
ifup --allow="${IFACE}" --all
and thereby get rid of the need for the ovs_ports setting entirely?
That is, could we reduce the amount of duplication in
/etc/network/interfaces, so that users only need the allow-<bridge>
lines and not the ovs_ports line?
(If that works then we'd want a similar change in the "stop" case,
of course.)
> + case "${IF_OVS_TYPE}" in
> + OVSBridge)
> + ovs_vsctl -- --may-exist add-br "${IFACE}" ${IF_OVS_OPTIONS}\
> + ${OVS_EXTRA+-- $OVS_EXTRA}
> +
> + if [ ! -z "${IF_OVS_PORTS}" ]; then
> + ifup --allow="${IFACE}" ${IF_OVS_PORTS}
> + fi
> + ;;
It would be nice to be able to infer the ovs_bridge setting for ports
from the allow-<bridge> line. I guess we'd have to use "sed" on
/etc/network/interfaces to do that, though. That may not be worth it.
I think that README.Debian is supposed to take the form of a series of
entries each of which ends in a line like the one at the end of the
top entry:
-- Ben Pfaff <[email protected]>, Mon, 30 Aug 2010 09:51:19 -0700
Of course you'd put in your own name and email and use the current
date and time. (The format of the date and time might be important;
some Debian tools care.)
"allow-ovs" and "allow-<bridge>" are only documented in the examples.
I'd document them in the initial description instead.
I'd drop the "reporting bugs" section at the end. It's normal for
Debian users to report Debian packaging bugs via the Debian
bug-tracker, and that's fine (they'll get to us that way too.)
Thanks,
Ben.
_______________________________________________
dev mailing list
[email protected]
http://openvswitch.org/mailman/listinfo/dev
