On May 8, 2012, at 6:43 AM, Ben Pfaff wrote:
> I'd add a new-line before the first port, so that the formatting looks
> the same for each port.
This seems like a general issue with the way we print messages. For example:
OFPT_FEATURES_REPLY (xid=0x1): dpid:0000505400000001
n_tables:2, n_buffers:256
capabilities: FLOW_STATS TABLE_STATS PORT_STATS ARP_MATCH_IP
Do you think we should just always start the body on a separate line?
Obviously, this would be disruptive to scripts that expect a certain format.
Alternatively, I can just add a newline in ofp_print_ofpst_port_desc_reply()
before calling ofp_print_phy_ports().
I realized that I didn't add a NEWS items, so I'm planning to add the following:
@@ -10,6 +10,11 @@ post-v1.6.0
interface.
- OpenFlow:
- Added support to mask nd_target for ICMPv6 neighbor discovery flows.
+ - Added support for OpenFlow 1.3 port description (OFPMP_PORT_DESC)
+ multipart messages.
+ - ovs-ofctl:
+ - Added the "dump-ports-desc" command to retrieve port
+ information using the new port description multipart messages.
--Justin
_______________________________________________
dev mailing list
[email protected]
http://openvswitch.org/mailman/listinfo/dev
