On Tue, May 08, 2012 at 10:58:04AM -0700, Justin Pettit wrote: > > On May 8, 2012, at 10:47 AM, Ben Pfaff wrote: > > > On Tue, May 08, 2012 at 10:42:11AM -0700, Justin Pettit wrote: > >> Not all ports may fit in a Features Reply, so if that's the case, then > >> use the new port description stat message for looking up ports. > >> > >> Signed-off-by: Justin Pettit <jpet...@nicira.com> > > > > All I noticed is that in fetch_port_by_stats() we should check that > > the reply is actually a port_desc stats reply (perhaps with > > ofputil_decode_msg_type()), since right now AFAICT it will try to > > interpret an error reply as a stats reply, which probably will work > > out badly. > > Good point. How about the incremental at the end of the message?
The incremental pleases me. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
