Thanks a lot. I made a commit out of it and sent it out in the standard form for review.
On Wed, May 09, 2012 at 05:58:26AM -0700, bkruger wrote: > Signed-off-by: Brian Kruger <bkruger+ovs...@gmail.com> > > On Tue, May 8, 2012 at 9:32 AM, Ben Pfaff <b...@nicira.com> wrote: > > > On Mon, May 07, 2012 at 08:55:56PM -0700, bkruger wrote: > > > If the daemon(s) aren't running for whatever reason, the RHEL ovs > > > ifup/ifdown scripts don't take that into account and an attempt to > > reboot a > > > system could take forever. (literally. endless loop!) Here are a couple > > of > > > patches (one of ifup, one for ifdown) to add timeouts (10 seconds), > > because > > > it runs per interface you have configured and that could take awhile to > > > reboot a system if needed. > > > > > > Files modified: > > > > > > openvswitch-1.4.1/rhel/etc_sysconfig_network-scripts_ifdown-ovs > > > openvswitch-1.4.1/rhel/etc_sysconfig_network-scripts_ifup-ovs > > > > > > Note: These are tested, with the exception of bonding as I don't have a > > > system handy with both network connections, but I followed the working > > > format I used on the others and they work fine. > > > > Would you mind giving me a Signed-off-by: line? Something like: > > Signed-off-by: B. Kruger <bkruger+ovs...@gmail.com> > > > > By doing this, you are agreeing to the Developer's Certificate of Origin > > (see below for more details). > > > > Developer's Certificate of Origin > > --------------------------------- > > > > To help track the author of a patch as well as the submission chain, > > and be clear that the developer has authority to submit a patch for > > inclusion in openvswitch please sign off your work. The sign off > > certifies the following: > > > > Developer's Certificate of Origin 1.1 > > > > By making a contribution to this project, I certify that: > > > > (a) The contribution was created in whole or in part by me and I > > have the right to submit it under the open source license > > indicated in the file; or > > > > (b) The contribution is based upon previous work that, to the best > > of my knowledge, is covered under an appropriate open source > > license and I have the right under that license to submit that > > work with modifications, whether created in whole or in part > > by me, under the same open source license (unless I am > > permitted to submit under a different license), as indicated > > in the file; or > > > > (c) The contribution was provided directly to me by some other > > person who certified (a), (b) or (c) and I have not modified > > it. > > > > (d) I understand and agree that this project and the contribution > > are public and that a record of the contribution (including all > > personal information I submit with it, including my sign-off) is > > maintained indefinitely and may be redistributed consistent with > > this project or the open source license(s) involved. > > _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
