Thanks, I pushed it to master and branch-1.7. (1.6 and earlier didn't have NXAST_CONTROLLER.)
On Mon, May 14, 2012 at 11:21:37AM -0700, Ethan Jackson wrote: > Looks good, thanks. > > Ethan > > On Fri, May 4, 2012 at 2:50 PM, Ben Pfaff <[email protected]> wrote: > > Found by inspection. > > > > Signed-off-by: Ben Pfaff <[email protected]> > > --- > > lib/ofp-util.c | 8 +++++--- > > 1 files changed, 5 insertions(+), 3 deletions(-) > > > > diff --git a/lib/ofp-util.c b/lib/ofp-util.c > > index 43776d5..d3ba068 100644 > > --- a/lib/ofp-util.c > > +++ b/lib/ofp-util.c > > @@ -3715,11 +3715,13 @@ ofputil_put_action(enum ofputil_action_code code, > > struct ofpbuf *buf) > > bool > > action_outputs_to_port(const union ofp_action *action, ovs_be16 port) > > { > > - switch (ntohs(action->type)) { > > - case OFPAT10_OUTPUT: > > + switch (ofputil_decode_action(action)) { > > + case OFPUTIL_OFPAT10_OUTPUT: > > return action->output.port == port; > > - case OFPAT10_ENQUEUE: > > + case OFPUTIL_OFPAT10_ENQUEUE: > > return ((const struct ofp_action_enqueue *) action)->port == port; > > + case OFPUTIL_NXAST_CONTROLLER: > > + return port == htons(OFPP_CONTROLLER); > > default: > > return false; > > } > > -- > > 1.7.2.5 > > > > _______________________________________________ > > dev mailing list > > [email protected] > > http://openvswitch.org/mailman/listinfo/dev _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
