On Tue, May 22, 2012 at 02:23:13PM -0700, Ethan Jackson wrote:
> There's some trailing whitespace added to the ofctl man page.
Thanks, fixed.
> Otherwise looks good. May benefit from a unit test.
Good idea, I added this to the existing unit test:
diff --git a/tests/ofproto.at b/tests/ofproto.at
index 3113577..98942e5 100644
--- a/tests/ofproto.at
+++ b/tests/ofproto.at
@@ -68,7 +68,14 @@ for command_config_state in \
'up 0 0' \
'noflood NO_FLOOD 0' \
'down PORT_DOWN,NO_FLOOD LINK_DOWN' \
- 'flood PORT_DOWN LINK_DOWN'
+ 'flood PORT_DOWN LINK_DOWN' \
+ 'no-receive PORT_DOWN,NO_RECV LINK_DOWN' \
+ 'no-forward PORT_DOWN,NO_RECV,NO_FWD LINK_DOWN' \
+ 'no-packet-in PORT_DOWN,NO_RECV,NO_FWD,NO_PACKET_IN LINK_DOWN' \
+ 'forward PORT_DOWN,NO_RECV,NO_PACKET_IN LINK_DOWN' \
+ 'packet-in PORT_DOWN,NO_RECV LINK_DOWN' \
+ 'up NO_RECV 0' \
+ 'receive 0 0'
do
set $command_config_state
command=$[1] config=`echo $[2] | sed 's/,/ /g'` state=$[3]
I'll push this soon.
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
