On Wed, Jun 06, 2012 at 05:44:39PM -0700, Ethan Jackson wrote:
> Open vSwitch refuses to mirror certain destination addresses in
> addition to those classified by eth_addr_is_reserved(). Looking
> through the uses of eth_addr_is_reserved(), one finds that no
> callers should be using the additional addresses which mirroring
> drops. This patch folds the additional addresses dropped in the
> mirroring code, into the more general eth_addr_is_reserverd()
> function.
>
> This patch also changes the implementation in a way that is
> slightly less efficient, but much easier to read and extend int he
> future.
>
> Bug #11755.
> Signed-off-by: Ethan Jackson <[email protected]>
Seems reasonable. Should we mention this in NEWS?
I'd mark the following structure "const" also:
> + static struct masked_eth_addr mea[] = {
> + { /* STP, IEEE pause frames, and other reserved protocols. */
> + {0x01, 0x08, 0xc2, 0x00, 0x00, 0x00},
> + {0xff, 0xff, 0xff, 0xff, 0xff, 0xf0}},
> +
Otherwise looks good, thank you.
_______________________________________________
dev mailing list
[email protected]
http://openvswitch.org/mailman/listinfo/dev
