On Thu, Jun 14, 2012 at 11:35:26PM -0700, Ben Pfaff wrote: > This mainly changes ofpact_to_openflow11() to use the > ofpact_to_nxast() function that I introduced. I think this makes > ofpact_to_openflow11() more readable; certainly shorter. > > I also broke ofpacts_to_openflow() into two functions > ofpacts_to_openflow10() and ofpacts_to_openflow11(). I might be > wrong, but my feeling is that the messages and circumstances in > which actions are present in OpenFlow 1.0 and 1.1 are different > enough that there won't be any caller that would want to blindly > pass along a protocol value.
This all seems very reasonable to me. Please consider merging this patch and "ofp-actions: Support encoding OpenFlow 1.1 instructions and actions." I'm happy for you to put your name as the Author of a merged patch. > We don't have any functions for encoding instructions yet. _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
