Looks good to me, thanks. Ethan
On Thu, Jul 5, 2012 at 12:58 PM, Ben Pfaff <[email protected]> wrote: > os.listdir("/proc/%d/fd" % pid) throws OSError if 'pid' died since the > list of pids was obtained. > > Bug #12375. > Reported-by: Amey Bhide <[email protected]> > Signed-off-by: Ben Pfaff <[email protected]> > --- > AUTHORS | 1 + > utilities/ovs-check-dead-ifs.in | 7 ++++++- > 2 files changed, 7 insertions(+), 1 deletions(-) > > diff --git a/AUTHORS b/AUTHORS > index 47f6ea3..bf8c149 100644 > --- a/AUTHORS > +++ b/AUTHORS > @@ -80,6 +80,7 @@ Alan Shieh [email protected] > Alban Browaeys [email protected] > Alex Yip [email protected] > Alexey I. Froloff [email protected] > +Amey Bhide [email protected] > André Ruß [email protected] > Andreas Beckmann [email protected] > Atzm Watanabe [email protected] > diff --git a/utilities/ovs-check-dead-ifs.in b/utilities/ovs-check-dead-ifs.in > index 53185d6..9b806ed 100755 > --- a/utilities/ovs-check-dead-ifs.in > +++ b/utilities/ovs-check-dead-ifs.in > @@ -62,7 +62,12 @@ for pid in os.listdir("/proc"): > except ValueError: > continue > > - for fd in os.listdir("/proc/%d/fd" % pid): > + try: > + fds = os.listdir("/proc/%d/fd" % pid) > + except OSError: > + continue > + > + for fd in fds: > try: > fd = int(fd) > except ValueError: > -- > 1.7.2.5 > > _______________________________________________ > dev mailing list > [email protected] > http://openvswitch.org/mailman/listinfo/dev _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
