On Thu, Jul 05, 2012 at 03:38:37PM -0700, Ethan Jackson wrote: > The ovs-lib strace wrapper requires the -D (run tracer process as a > detached grandchild, not as parent) option which does not exist in > older versions. This patch falls back to attaching to the running > process when the -D option does not exists. > > Signed-off-by: Ethan Jackson <et...@nicira.com>
I don't think POSIX defines the behavior of "&>/dev/null". Please use ">/dev/null 2>&1" instead, which is well-defined. I'm worried about word-splitting on $logdir/$daemon.strace.log (e.g. if $logdir happens to contain a space). I think it would be better to write -o "$logdir/$daemon.strace.log" in the "set" and "strace" commands, just to be sure. Thanks, Ben. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
