On Mon, Jul 23, 2012 at 11:36:40AM +0900, Simon Horman wrote: > the purpose of this series is to: > > * Add encoding of the OXM VLAN VID and VLAN PCP matches and; > * Correct the decoding of OXM VLAN VID and VLAN PCP matches > without breaking ovs-ofctl add-flows, which uses some of the > same code paths. > > This series differs to v2 in that internally the CFI bit is now > honoured which in turn allows it to be honoured for the OXM VLAN VID > match. > > Backwards compatibility for ovs-ofcfl add-flows dl_vlan and dl_vlan_pcp > is provided by the first patch in this series.
The approach here bugs me a bit, especially the way that it puts an extra bit into the PCP. I think that it makes more sense, instead of trying to treat the OF1.0 dl_vlan and the OF1.2 OXM_OF_VLAN_VID the same way, to invent separate meta-flow fields for them. I've written up an alternative patch series that takes that approach, which still uses three of your 6 patches and part of a fourth, and I'll send it out in a minute for review. _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
