[ovs-dev] [PATCH v3 12/12] ofproto-dpif: teach goto-table instruction packet-in

[Isaku Yamahata]

When goto-table instruction results in table miss, generate packet-in event

Signed-off-by: Isaku Yamahata <yamah...@valinux.co.jp>
---
v3
- changed for OFPACT_GOTO_ABLE

v2
- minor change to compile
---
 ofproto/ofproto-dpif.c |   30 +++++++++++++++++++++---------
 1 files changed, 21 insertions(+), 9 deletions(-)

diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c
index 3e9c744..0d36f6f 100644
--- a/ofproto/ofproto-dpif.c
+++ b/ofproto/ofproto-dpif.c
@@ -4971,7 +4971,7 @@ compose_output_action(struct action_xlate_ctx *ctx, 
uint16_t ofp_port)
 
 static void
 xlate_table_action(struct action_xlate_ctx *ctx,
-                   uint16_t in_port, uint8_t table_id)
+                   uint16_t in_port, uint8_t table_id, bool may_packet_in)
 {
     if (ctx->recurse < MAX_RESUBMIT_RECURSION) {
         struct ofproto_dpif *ofproto = ctx->ofproto;
@@ -5007,6 +5007,17 @@ xlate_table_action(struct action_xlate_ctx *ctx,
             ctx->resubmit_hook(ctx, rule);
         }
 
+        if (rule == NULL && may_packet_in) {
+            /* TODO:XXX
+             * check if table configuration flags
+             * OFPTC_TABLE_MISS_CONTROLLER, default.
+             * OFPTC_TABLE_MISS_CONTINUE,
+             * OFPTC_TABLE_MISS_DROP
+             * When OF1.0, OFPTC_TABLE_MISS_CONTINUE is used. What to do?
+             */
+            rule = rule_dpif_miss_rule(ofproto, &ctx->flow);
+        }
+
         if (rule) {
             struct rule_dpif *old_rule = ctx->rule;
 
@@ -5048,7 +5059,7 @@ xlate_ofpact_resubmit(struct action_xlate_ctx *ctx,
         table_id = ctx->table_id;
     }
 
-    xlate_table_action(ctx, in_port, table_id);
+    xlate_table_action(ctx, in_port, table_id, false);
 }
 
 static void
@@ -5160,7 +5171,7 @@ compose_dec_ttl(struct action_xlate_ctx *ctx)
 
 static void
 xlate_output_action(struct action_xlate_ctx *ctx,
-                    uint16_t port, uint16_t max_len)
+                    uint16_t port, uint16_t max_len, bool may_packet_in)
 {
     uint16_t prev_nf_output_iface = ctx->nf_output_iface;
 
@@ -5171,7 +5182,7 @@ xlate_output_action(struct action_xlate_ctx *ctx,
         compose_output_action(ctx, ctx->flow.in_port);
         break;
     case OFPP_TABLE:
-        xlate_table_action(ctx, ctx->flow.in_port, 0);
+        xlate_table_action(ctx, ctx->flow.in_port, 0, may_packet_in);
         break;
     case OFPP_NORMAL:
         xlate_normal(ctx);
@@ -5211,7 +5222,7 @@ xlate_output_reg_action(struct action_xlate_ctx *ctx,
 {
     uint64_t port = mf_get_subfield(&or->src, &ctx->flow);
     if (port <= UINT16_MAX) {
-        xlate_output_action(ctx, port, or->max_len);
+        xlate_output_action(ctx, port, or->max_len, false);
     }
 }
 
@@ -5228,7 +5239,7 @@ xlate_enqueue_action(struct action_xlate_ctx *ctx,
     error = dpif_queue_to_priority(ctx->ofproto->dpif, queue_id, &priority);
     if (error) {
         /* Fall back to ordinary output action. */
-        xlate_output_action(ctx, enqueue->port, 0);
+        xlate_output_action(ctx, enqueue->port, 0, false);
         return;
     }
 
@@ -5323,7 +5334,7 @@ xlate_bundle_action(struct action_xlate_ctx *ctx,
     if (bundle->dst.field) {
         nxm_reg_load(&bundle->dst, port, &ctx->flow);
     } else {
-        xlate_output_action(ctx, port, 0);
+        xlate_output_action(ctx, port, 0, false);
     }
 }
 
@@ -5447,7 +5458,7 @@ do_xlate_action(const struct ofpact *a, struct 
action_xlate_ctx *ctx)
     switch (a->type) {
     case OFPACT_OUTPUT:
         xlate_output_action(ctx, ofpact_get_OUTPUT(a)->port,
-                            ofpact_get_OUTPUT(a)->max_len);
+                            ofpact_get_OUTPUT(a)->max_len, true);
         break;
 
     case OFPACT_CONTROLLER:
@@ -5589,7 +5600,8 @@ do_xlate_action(const struct ofpact *a, struct 
action_xlate_ctx *ctx)
     case OFPACT_GOTO_TABLE: {
         struct ofpact_goto_table *ogt = ofpact_get_GOTO_TABLE(a);
         xlate_table_action(ctx, ctx->flow.in_port,
-                           ogt->table_id == 255? ctx->table_id: ogt->table_id);
+                           ogt->table_id == 255? ctx->table_id: ogt->table_id,
+                           true);
                            /* TODO:XXX remove 255 */
         return false;
     }
-- 
1.7.1.1

_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev