On Wed, Jul 25, 2012 at 02:04:12PM +0900, Simon Horman wrote: > On Thu, Jul 19, 2012 at 11:28:47PM -0700, Ben Pfaff wrote: > > OpenFlow headers are not as uniform as they could be, with size, alignment, > > and numbering changes from one version to another and across varieties > > (e.g. ordinary messages vs. "stats" messages). Until now the Open vSwitch > > internal APIs haven't done a good job of abstracting those differences in > > header formats. This commit changes that; from this commit forward very > > little code actually needs to understand the header format or numbering. > > Instead, it can just encode or decode, or pull or put, the header using > > a more abstract API using the ofpraw_, ofptype_, and other APIs in the > > new ofp-msgs module. > > > > Signed-off-by: Ben Pfaff <b...@nicira.com> > > I have run into a lot of this code while porting my Open Flow 1.2 patches, > which I estimate I am now about half way though. I don't have any > objections to anything I see here. > > As discussed elsewhere[1] I think that lib/ofp-msgs.c needs to be slightly > enhanced in order to handle OpenFlow 1.2, so assuming the changes you > indicated you will roll into this patch are rolled in.
Thanks. I did roll those in. > Reviewed-by: Simon Horman <ho...@verge.net.au> Added. > [1] elsewhere: http://openvswitch.org/pipermail/dev/2012-July/019442.html > "Re: [PATCH 05/24] ofp-util: Allow decoder to use OFPT11_STATS_{REQUEST, > REPLY} for OpenFlow 1.2" ... > I know that breaking up is hard to do, > but something shy of 5000 lines with a bonus 1000 lines of generated code > is a big patch to review. Well, thanks for taking it on. (If you'd complained earlier I would have at least considered breaking it up, but I don't see a point anymore.) _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
