I currently have 8 failing unit tests on FreeBSD: testsuite: 186 188 474 1045 1054 1055 1056 1057 failed
Here are some notes on each of them. I have fixes / workarounds for all but the first two and will send patches shortly. 186, 188 This is the issue in my recent post 'FreeBSD vconn refuse-connection unit test race condition'. I have a simple test case that demonstrates the difference in behaviour between FreeBSD and Linux, at http://people.freebsd.org/~emaste/sockets/closed_socket_write.py . The send() call returns EPIPE on FreeBSD and ECONNRESET on Linux. (Fixing that will address only one of the two different failures I've seen though.) 474 This one fails due to a lack of \b in FreeBSD sed (at least in normal mode). It seems that the time always comes at the end of the line, so I went with the following change -- I'll send it separately as a patch: --- a/tests/ofproto-dpif.at +++ b/tests/ofproto-dpif.at @@ -962,7 +962,7 @@ ovs-appctl -t test-netflow exit AT_CHECK([[sed -e 's/, uptime [0-9]*// s/, now [0-9.]*// -s/time \([0-9]*\)\.\.\.\1\b/time <moment>/ +s/time \([0-9]*\)\.\.\.\1$/time <moment>/ s/time [0-9]*\.\.\.[0-9]*/time <range>/ ' netflow.log]], [0], [header: v5, seq 0, engine 2,1 1045 This one comes from the "sort | xargs echo" in ovs-vsctl.at. As the FreeBSD xargs man page states, -r Compatibility with GNU xargs. The GNU version of xargs runs the utility argument at least once, even if xargs input is empty, and it supports a -r option to inhibit this behavior. The FreeBSD version of xargs does not run the utility argument on empty input, but it supports the -r option for command-line compatibil- ity with GNU xargs, but the -r option does nothing in the FreeBSD version of xargs. So passing the -r argument would make Linux and FreeBSD behave the same, but would require changing VSCTL_CHECK_FIND since we'd no longer have a blank line for the [] case. Probably the easiest fix is to add a m4_define([VSCTL_CHECK_FIND_EMPTY] to explicitly match an empty bridge list. I'll send a patch for this as well. 1054 1055 1056 1057 These fail because interface-reconfigure starts with #!/usr/bin/python and we install python in /usr/local/bin. This can be fixed via --- a/xenserver/opt_xensource_libexec_interface-reconfigure +++ b/xenserver/opt_xensource_libexec_interface-reconfigure @@ -1,4 +1,4 @@ -#!/usr/bin/python +#!/usr/bin/env python # # Copyright (c) 2008,2009 Citrix Systems, Inc. # _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
