On Mon, Jul 30, 2012 at 6:30 PM, Ansis Atteka <aatt...@nicira.com> wrote:
> > > On Mon, Jul 30, 2012 at 3:18 PM, Ben Pfaff <b...@nicira.com> wrote: > >> Here's a series that takes the "bug 681880" series from last week >> a step further, both fixing a bug that Bastian Blank pointed out >> (regarding compaction) and making the implementation safer. >> >> Ansis already reviewed the first three patches. They are already >> uploaded to Debian but I haven't committed them to any branch yet, >> so here they are again for completeness: >> lockfile: Fix hang locking through a dangling symlink. >> ovsdb: Make "ovsdb-tool create" work through a dangling symlink. >> debian: Move database from /etc/openvswitch to /var/lib/openvswitch. >> >> The remaining patches need review: >> Make the location of the database separately configurable. >> debian: Configure Debian packages to use /var/lib/openvswitch for >> conf.db. >> tests: Slightly generalize utility function tests. >> util: New function follow_symlinks(). >> lockfile: Be more forgiving about lockfiles for symlinks. >> ovsdb: Do not replace symlinks by regular files during compaction. >> >> Makefile.am | 1 + >> REPORTING-BUGS | 2 +- >> configure.ac | 1 + >> debian/automake.mk | 1 + >> debian/openvswitch-switch.dirs | 1 + >> debian/openvswitch-switch.postinst | 15 +++ >> debian/openvswitch-switch.postrm | 4 +- >> debian/openvswitch-switch.prerm | 50 ++++++++++ >> debian/rules | 4 +- >> lib/automake.mk | 2 + >> lib/dirs.c.in | 9 ++- >> lib/dirs.h | 3 +- >> lib/lockfile.c | 79 +++++++-------- >> lib/util.c | 85 >> +++++++++++++++++ >> lib/util.h | 3 + >> m4/openvswitch.m4 | 10 ++ >> ovsdb/file.c | 7 +- >> ovsdb/log.c | 13 ++- >> ovsdb/ovsdb-server.1.in | 2 +- >> ovsdb/ovsdb-server.c | 2 +- >> ovsdb/ovsdb-tool.1.in | 2 +- >> ovsdb/ovsdb-tool.c | 24 +++-- >> python/automake.mk | 1 + >> python/ovs/dirs.py | 1 + >> tests/file_name.at | 97 >> +++++++++++++++++++ >> tests/library.at | 15 ++- >> tests/lockfile.at | 2 + >> tests/ofproto-macros.at | 3 +- >> tests/ovs-monitor-ipsec.at | 1 + >> tests/ovs-xapi-sync.at | 1 + >> tests/ovsdb-server.at | 15 +++- >> tests/ovsdb-tool.at | 17 +++- >> tests/test-lockfile.c | 68 +++++++++++++- >> tests/test-util.c | 99 >> +++++++++++++------ >> tests/unixctl-py.at | 2 + >> tests/vlog.at | 4 + >> utilities/bugtool/ovs-bugtool.in | 4 +- >> .../bugtool/plugins/system-logs/openvswitch.xml | 3 +- >> utilities/ovs-ctl.8 | 3 +- >> utilities/ovs-ctl.in | 7 +- >> utilities/ovs-lib.in | 2 + >> 41 files changed, 554 insertions(+), 111 deletions(-) >> create mode 100755 debian/openvswitch-switch.prerm >> >> -- >> 1.7.2.5 >> >> _______________________________________________ >> dev mailing list >> dev@openvswitch.org >> http://openvswitch.org/mailman/listinfo/dev >> > I will review these series. > > Thanks > Ansis > "git am" says: Applying: lockfile: Fix hang locking through a dangling symlink. Applying: ovsdb: Make "ovsdb-tool create" work through a dangling symlink. Applying: debian: Move database from /etc/openvswitch to /var/lib/openvswitch. Applying: Make the location of the database separately configurable. /home/aatteka/openvswitch/.git/rebase-apply/patch:126: trailing whitespace. [dbdir], /home/aatteka/openvswitch/.git/rebase-apply/patch:127: trailing whitespace. AC_HELP_STRING([--with-dbdir=DIR], warning: 2 lines add whitespace errors. Applying: debian: Configure Debian packages to use /var/lib/openvswitch for conf.db. Applying: tests: Slightly generalize utility function tests. Applying: util: New function follow_symlinks(). Applying: lockfile: Be more forgiving about lockfiles for symlinks. Applying: ovsdb: Do not replace symlinks by regular files during compaction.
_______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
