On Mon, Jul 30, 2012 at 11:10:23PM -0400, Ed Maste wrote: > On 30 July 2012 20:16, Ben Pfaff <b...@nicira.com> wrote: > > On Mon, Jul 30, 2012 at 07:23:48PM -0400, Ed Maste wrote: > >> The FreeBSD version of xargs does not run the utility argument on empty > >> input, while GNU xargs runs it at least once, even with empty input. As > >> a result on FreeBSD VSCTL_CHECK_FIND returned no output for an empty > >> bridge list while on Linux it returned a single blank line. Add a new > >> VSCTL_CHECK_FIND_EMPTY to explicitly match an empty bridge list. > >> > >> Signed-off-by: Ed Maste <ema...@freebsd.org> > > > > I think that we could avoid the need for VSCTL_CHECK_FIND_EMPTY by > > changing > > | sort | xargs echo > > in VSCTL_CHECK_FDIN to > > m4_if([$2], [], [], [| sort | xargs echo]) > > I tried it and it doesn't work - I think because ovs-vsctl is > producing no output and the AT_CHECK requires a newline. It's a bit > hackish but can make work with echo `...` - what do you think?
Sure, that's good enough. I like it better than two versions of the macro. Thanks, Ben. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
