On Tue, Jul 31, 2012 at 09:50:55AM -0400, Ed Maste wrote: > On FreeBSD some of the test-vconn.c tests failed intermittently due > to timing variations in a TCP localhost connection. > > - If we receive EAGAIN for certain functions, retry. > > - Allow EPIPE in addition to ECONNRESET in some cases. A write() to a > socket where the other side has closed returns EPIPE on FreeBSD and > ECONNRESET on Linux. > > Signed-off-by: Ed Maste <ema...@freebsd.org>
This seems OK, but I think we can do a little better, by using proper blocking instead of a busy-retry loop, and using fewer macros. I sent out a 2-patch series that works this way: http://openvswitch.org/pipermail/dev/2012-July/019825.html http://openvswitch.org/pipermail/dev/2012-July/019824.html Please review it. Thanks, Ben. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev