On Tue, Jul 31, 2012 at 12:51:37PM -0400, Ed Maste wrote:
> FreeBSD doesn't have "date -r" and calls its sha1 hash tool tool "sha1."
> 
> Signed-off-by: Ed Maste <ema...@freebsd.org>
> ---
> Defining shell functions within a case statement is a little odd but I'd
> rather not have several functions each with the same case statement in
> them.  I could perhaps move these into an ovs-osdep.subr if that seems
> cleaner.
> 
> With this change (and after enabling SSL in configure) all but 3 skipped
> tests in "make check" pass on FreeBSD.

Is there any reason we can't indent the code inside each case?
Otherwise I'm happy with this.

Thanks,

Ben.
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to